[alsa-devel] [PATCH 1/1] drm/i915/audio: apply SKL codec wake up patch to BXT

[Takashi Iwai]

On Thu, 19 Nov 2015 10:09:01 +0100,
Jani Nikula wrote:
> 
> On Thu, 19 Nov 2015, Jani Nikula <jani.nikula at intel.com> wrote:
> > On Thu, 19 Nov 2015, han.lu at intel.com wrote:
> >> From: "Lu, Han" <han.lu at intel.com>
> >>
> >> Signed-off-by: Lu, Han <han.lu at intel.com>
> >>
> >> diff --git a/drivers/gpu/drm/i915/intel_audio.c b/drivers/gpu/drm/i915/intel_audio.c
> >> index 63d4706..8310bf3 100644
> >> --- a/drivers/gpu/drm/i915/intel_audio.c
> >> +++ b/drivers/gpu/drm/i915/intel_audio.c
> >> @@ -591,7 +591,8 @@ static void i915_audio_component_codec_wake_override(struct device *dev,
> >>  	struct drm_i915_private *dev_priv = dev_to_i915(dev);
> >>  	u32 tmp;
> >>  
> >> -	if (!IS_SKYLAKE(dev_priv) && !IS_KABYLAKE(dev_priv))
> >> +	if (!IS_SKYLAKE(dev_priv) && !IS_BROXTON(dev_priv) &&
> >> +			!IS_KABYLAKE(dev_priv))
> >
> > How about if (INTEL_INFO(dev_priv)->gen < 9)?
> 
> Oh, and I guess we also wonder why this is only relevant for the latest
> platforms?

My understanding is that it's a workaround specific to HSW/BDW.
It's issued only during the audio controller initialization and at the
resume.  But I never know why it's needed, it's a black magic :)


Takashi