[alsa-devel] [PATCH] ASoC: Intel: fix broadwell module removing failed issue

[Liam Girdwood]

On Thu, 2015-05-28 at 17:09 +0200, Takashi Iwai wrote:
> At Thu, 28 May 2015 14:14:18 +0800,
> Jie Yang wrote:
> > 
> > From: Liam Girdwood <liam.r.girdwood at linux.intel.com>
> > 
> > In haswell-pcm module unloading, we can't free runtime modules
> > directly, for they may be already freed in runtime suspend.
> > 
> > Here add executing suspend call to unload runtime modules, only
> > for status not equal to RPM_SUSPEND, to fix broadwell module
> > removing failed issue.
> 
> What if a kernel is built without PM support?  (Practically seen, it's
> never any serious problem, though.)
> 

Keyon, it sounds like you will still need hsw_pcm_free_modules() and
should call it after the PM put/disable on module remove. You will need
to add some code too that will check the memory state prior to doing any
unloading though....

Liam



---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.