[alsa-devel] [PATCH 5/5] sound: sound_firmware: Fix invalid use of vfs_read()
Takashi Iwai
tiwai at suse.de
Tue May 26 14:41:52 CEST 2015
It should use kernel_read() instead of vfs_read() to load a firmware
binary onto the kernel pages.
Signed-off-by: Takashi Iwai <tiwai at suse.de>
---
sound/sound_firmware.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/sound_firmware.c b/sound/sound_firmware.c
index b155137ee312..026347643c81 100644
--- a/sound/sound_firmware.c
+++ b/sound/sound_firmware.c
@@ -12,7 +12,6 @@ static int do_mod_firmware_load(const char *fn, char **fp)
struct file* filp;
long l;
char *dp;
- loff_t pos;
filp = filp_open(fn, 0, 0);
if (IS_ERR(filp))
@@ -34,8 +33,7 @@ static int do_mod_firmware_load(const char *fn, char **fp)
fput(filp);
return 0;
}
- pos = 0;
- if (vfs_read(filp, dp, l, &pos) != l)
+ if (kernel_read(filp, 0, dp, l) != l)
{
printk(KERN_INFO "Failed to read '%s'.\n", fn);
vfree(dp);
--
2.4.1
More information about the Alsa-devel
mailing list