[alsa-devel] [PATCH 1/2] ASoC: zx: Add ZTE zx296702 I2S DAI driver

[Mark Brown]

On Wed, May 20, 2015 at 07:06:11PM +0800, Jun Nie wrote:
> Add ZTE zx296702 I2S DAI driver

This looks good but depends on the DMA driver and a couple of small
nits:

> +config ZX296702_I2S
> +	bool "ZX296702 i2s"

I see no reason for this to be bool as opposed to a tristate - why not
let people build it as a module?

> +	default:
> +		dev_err(cpu_dai->dev, "Unknwon master/slave format\n");

The driver consistently misspells unknown.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150522/1f8ef4b2/attachment.sig>