[alsa-devel] [PATCH 1/4 v2] dmaengine: rcar-dmac: fixup spinlock in rcar-dmac

Vinod Koul vinod.koul at intel.com
Fri May 22 14:28:05 CEST 2015


On Thu, May 21, 2015 at 03:48:38AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> 
> Current rcar-dmac driver is using spin_lock_irq() / spin_unlock_irq()
> in some functions. But, some other driver might call DMAEngine API
> during interrupt disabled. In such case, rcar-dmac side spin_unlock_irq()
> forcefully allows all interrupts. Therefore, other driver receives
> unexpected interruption, and its exclusive access control will be broken.
> This patch replaces spin_lock_irq() to spin_lock_irqsave(),
> and spin_unlock_irq() to spin_unlock_irqrestore().
> 
> Reported-by: Cao Minh Hiep <cm-hiep at jinso.co.jp>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx at renesas.com>
> Tested-by: Keita Kobayashi <keita.kobayashi.ym at renesas.com>
Acked-by: Vinod Koul <vinod.koul at intel.com>

Mark, please apply this thru your tree

Thanks
-- 
~Vinod



More information about the Alsa-devel mailing list