[alsa-devel] ALC298 headset mode support

[Kailang]

Hi Takashi, 

New patch attached.
ALC298 hidden register was very similar to ALC286/ALC288.
Many Thanks. ^^

BR,
Kailang

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de] 
> Sent: Monday, May 11, 2015 8:35 PM
> To: Kailang
> Cc: (alsa-devel at alsa-project.org)
> Subject: Re: ALC298 headset mode support
> 
> At Mon, 11 May 2015 08:30:28 +0000,
> Kailang wrote:
> > 
> > Hi Takashi,
> >  
> > I finished the alc298 headset mode supported.
> > But it only tested via our develop system.
> ....
> > @@ -3801,6 +3804,8 @@ static void 
> alc_headset_mode_ctia(struct hda_codec *codec)
> > 	case 0x10ec0283:
> > 		alc_process_coef_fw(codec, coef0233);
> >  		break;
> > +	case 0x10ec0298:
> > +		alc_update_coef_idx(codec, 0x8e, 0x0070, 0x0020);
> > 	case 0x10ec0286:
> 
> I suppose you didn't forget break in the above, right?
Yes.

> If so, add a comment like /* fallthrough */ to indicate that 
> it's the intentional code.  Ditto for other similar lines.
> 
> 
> thanks,
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-alc298-headset-mode.patch
Type: application/octet-stream
Size: 2470 bytes
Desc: 0001-alc298-headset-mode.patch
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150512/c4bba621/attachment-0001.obj>