[alsa-devel] [PATCH 0/3] ASoC: DPCM can care FE/BE merged format

Mark Brown broonie at kernel.org
Mon May 11 18:15:45 CEST 2015


On Mon, May 11, 2015 at 04:14:47AM +0000, Kuninori Morimoto wrote:

> > Not quite sure what "flag control" is here, sorry?

> Sorry for my confusable words.
> Takashi mentioned

> 	>     .dpcm_merged_foramt
> 	>     .dpcm_merged_rate
> 	>     .dpcm_merged_chan

> 	Better to have bit flags.

> I guess Takashi means like this

> 	u32 xxx_flags
> 	#define DPCM_xxxx_FORMAT	(1 << 0)
> 	#define DPCM_xxxx_RATE		(1 << 1)
> 	#define DPCM_xxxx_CHAN		(1 << 2)

> But, this .dpcm_merged_xxx is defined as

> 	unsigned int dpcm_merged_foramt:1;

> "flag control" here means #defined DPCM_xxxx_CHAN flag,
> and I think we don't need it.

OK, right.  Yes, we can probably live without.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150511/e6f6f02b/attachment-0001.sig>


More information about the Alsa-devel mailing list