[alsa-devel] [PATCH] ASoC: Intel: Enabled button jack for BSW platform with rt5650 codec

[Dylan Reid]

On Tue, May 5, 2015 at 2:49 PM, Mark Brown <broonie at kernel.org> wrote:
> On Mon, May 04, 2015 at 05:19:20PM -0700, yang.a.fang at intel.com wrote:
>> From: "Fang, Yang A" <yang.a.fang at intel.com>
>>
>> rt5650 codec supports 4 buttons detections so enabled it
>
>> @@ -43,6 +43,7 @@ struct cht_acpi_card {
>>  struct cht_mc_private {
>>       struct snd_soc_jack hp_jack;
>>       struct snd_soc_jack mic_jack;
>> +     struct snd_soc_jack btn_jack;
>>       struct cht_acpi_card *acpi_card;
>
> This is a bit weird - why are we adding an additional jack here, surely
> the button is attached to the mic jack here?  The jacks should
> correspond to the physical jacks on the system rather than the function
> so that users and applications can tie the jacks that we have in
> software to those physically on the system.
>
> Now I'm wondering if the headphone and microphone are expected to be a
> single jack here?

At least the Chromebook version will have a single combo jack.  I
would expect there to be a single jack created that reports all of hp,
mic, and buttons.

>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel at alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>