[alsa-devel] [PATCH 1/4] ASoC: rt5645: Redefine format config for rt5650

[Mark Brown]

On Fri, Mar 27, 2015 at 08:19:06PM +0800, Bard Liao wrote:
> rt5650 and rt5645 use different register bits for format configuration.
> This patch modifies rt5645_hw_params and rt5645_set_dai_fmt to support
> both codecs.

Applied all, thanks.

> I am think if we should use different codec driver for rt5645 and
> rt5650. In fact, they are different Die. What do you think?

Well, it depends on how big the differences are for software really.  If
they are mostly register compatible then it's just going to be a few
differences and the same code will work for both with small bits of per
device code.  If there are too many differences then you end up with
more code handling those differences than is shared and it becomes
better to split the drivers.  Right now this doesn't look too different
but I don't know what other changes you might need.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150327/8d76def8/attachment.sig>