[alsa-devel] [PATCH] ALSA: hda_intel: add AZX_DCAPS_I915_POWERWELL for skl

[Yang, Libin]

Hi Takashi,



> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Friday, March 27, 2015 3:57 PM
> To: Yang, Libin
> Cc: alsa-devel at alsa-project.org
> Subject: Re: [PATCH] ALSA: hda_intel: add
> AZX_DCAPS_I915_POWERWELL for skl
> 
> At Fri, 27 Mar 2015 15:10:04 +0800,
> libin.yang at intel.com wrote:
> >
> > From: Libin Yang <libin.yang at intel.com>
> >
> > HDMI/DP codec on SKL is in the power well.
> > The power well must be turned on before probing the
> > HDMI/DP codec.
> >
> > Signed-off-by: Libin Yang <libin.yang at intel.com>
> 
> So, was the previous question clarified?

Yes, I have confirmed with our silicon team.

> 
> This certainly sucks.  It means that the powerwell is on even you
> don't use the HDMI/DP at all.  If this is intended as a temporarily
> workaround, it should be mentioned so.  Please give more comments
> and
> backgrounds.

Yes, as this is added in the skl audio controller, even there is no HDMI/DP
codec, we should also add this flag. Otherwise the HDMI/DP codec
may not be detected correctly.

> 
> 
> thanks,
> 
> Takashi


Regards,
Libin
> 
> > ---
> >  sound/pci/hda/hda_intel.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> > index 15a8299..4744a96 100644
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -298,7 +298,8 @@ enum {
> >  	 AZX_DCAPS_SNOOP_TYPE(SCH))
> >
> >  #define AZX_DCAPS_INTEL_SKYLAKE \
> > -	(AZX_DCAPS_INTEL_PCH |
> AZX_DCAPS_SEPARATE_STREAM_TAG)
> > +	(AZX_DCAPS_INTEL_PCH |
> AZX_DCAPS_SEPARATE_STREAM_TAG |\
> > +	 AZX_DCAPS_I915_POWERWELL)
> >
> >  /* quirks for ATI SB / AMD Hudson */
> >  #define AZX_DCAPS_PRESET_ATI_SB \
> > --
> > 1.9.1
> >