[alsa-devel] [PATCH] ASoC: soc-core: call soc_cleanup_card_debugfs() from snd_soc_unregister_card()

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Tue Mar 24 10:00:17 CET 2015


Hi Takashi

> > snd_soc_register_card()       <-> snd_soc_unregister_card()
> >  - soc_init_card_debugfs()           ????
> >  - snd_soc_instantiate_card() <->  - soc_cleanup_card_resources()
> >    - soc_bind_dai_link()             - soc_remove_dai_links()
> >    - soc_probe_aux_dev()             - soc_remove_aux_dev()
> >    - card->probe()                   - card->remove()
> >    - ????                            - soc_cleanup_card_debugfs()
> 
> IMO, a better change would be to call soc_init_card_debugfs() in
> snd_soc_instantiate_card(), supposing that the debugfs is available
> only for instantiated objects.  This will fix the messy leakage at
> error paths, too.

OK, here we go.

My concern is that my next patch will "return ret" if snd_soc_instantiate_card()
was failed, but is it OK ?

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list