[alsa-devel] [PATCH v3 2/2] ALSA: hda - Remove jack kctls

[Jie, Yang]

> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai at suse.de]
> Sent: Saturday, March 21, 2015 12:22 AM
> To: Jie, Yang
> Cc: broonie at kernel.org; alsa-devel at alsa-project.org; Girdwood, Liam R
> Subject: Re: [alsa-devel] [PATCH v3 2/2] ALSA: hda - Remove jack kctls
> 
> At Fri, 20 Mar 2015 23:39:13 +0800,
> Jie Yang wrote:
> >
> > @@ -337,20 +335,16 @@ void snd_hda_jack_report_sync(struct
> hda_codec *codec)
> >  	jack = codec->jacktbl.list;
> >  	for (i = 0; i < codec->jacktbl.used; i++, jack++)
> >  		if (jack->nid) {
> > -			if (!jack->kctl || jack->block_report)
> > +			if (!jack->jack || jack->block_report)
> >  				continue;
> >  			state = get_jack_plug_state(jack->pin_sense);
> > -			snd_kctl_jack_report(codec->bus->card, jack->kctl,
> state);
> > -#ifdef CONFIG_SND_HDA_INPUT_JACK
> >  			if (jack->jack)
> 
> The check here is superfluous, as you already added in the above.
[Keyon] got it.
> 
> 
> thanks,
> 
> Takashi