[alsa-devel] [PATCH 03/12 v2] ASoC: rsnd-dpcm-card: add Renesas sound card support for DPCM

Kuninori Morimoto kuninori.morimoto.gx at renesas.com
Thu Mar 19 01:08:53 CET 2015


Hi Lars

> > +	card-name = "rsnd-ak4643";
> > +	format = "left_j";
> > +	bitclock-master = <&sndcodec>;
> > +	frame-master = <&sndcodec>;
> > +
> > +	routing = "ak4642-hifi Playback", "DAI0 Playback",
> > +		  "DAI0 Capture", "ak4642-hifi Capture";
> 
> This does not belong into the devicetree. These strings are all Linux
> driver specific.

Hmm... but this is already supported in simple-card ?
and snd_soc_of_parse_audio_routing() is soc-core function...

Is your favorite style like this ?

	compatible = "rsnd-ak4642-card";

	static struct of_device_id rsnd_card_of_match[] = {
		{ .compatible = "rsnd-ak4642-card", .data = &rsnd_ak4642_route },
		{ .compatible = "rsnd-xxxxxx-card", .data = &rsnd_xxxxxx_route },
		{},

# Hmm... DT...

Best regards
---
Kuninori Morimoto


More information about the Alsa-devel mailing list