[alsa-devel] [PATCH] ALSA: dice: fix wrong offsets for Dice interface

[Takashi Iwai]

At Mon, 09 Mar 2015 22:11:48 +0900,
Takashi Sakamoto wrote:
> 
> On Mar 1 2015 18:50, Takashi Iwai wrote:
> > At Sun,  1 Mar 2015 18:12:16 +0900,
> > Takashi Sakamoto wrote:
> >>
> >> For received packet stream, the offset of 'RX_SEQ_START' locates after
> >> the offset of 'RX_NUMBER_MIDI', although current macro and proc output
> >> includes wrong offsets.
> >>
> >> Fortunately, this bug doesn't affect streaming functionality because
> >> these macro is not used.
> >>
> >> This commit fixes these wrong macro and outputs.
> >>
> >> Signed-off-by: Takashi Sakamoto <o-takashi at sakamocchi.jp>
> > 
> > Applied, thanks.
> > 
> > 
> > Takashi
> 
> I realized this commit is completely wrong. These addresses were true
> but I did mis-operations to confirm it. Would you please revert this commit?
> 
> Against my previous comment, 'RX_NUMBER_AUDIO' is used in
> dice_read_mode_params(). This wrong patch causes mis-detection of
> audio/midi data channels (usually RX_SEQ_START is zero, therefore the
> number of audio data channel is detect zero, wrongly), thus Dice driver
> becomes to work badly, sorry...

Just submit a patch to revert the commit.  It's still in rc, and this
wasn't tagged to stable, so it's no big problem.


thanks,

Takashi