[alsa-devel] [PATCH 0/2][RFC] ALSA: core: optimizations for creating new controls

Takashi Sakamoto o-takashi at sakamocchi.jp
Sat Mar 7 05:57:22 CET 2015


On Mar 6 2015 00:58, Takashi Iwai wrote:
> At Fri,  6 Mar 2015 00:43:24 +0900,
> Takashi Sakamoto wrote:
>>
>> This patchset is for reducing executing time and stack usage at creating
>> new control instances. Nothing fixes.
>>
>> Takashi Sakamoto (2):
>>   ALSA: core: use precomputed table to check userspace control params
>>   ALSA: core: reduce stack usage related to snd_ctl_new()
> 
> Both look good, but just minor nitpicking: could you remove
> superfluous parentheses in cases like below?
> 
> 	if ((a > 0) && (b < 0)) ...
> 
> Most people are no lispers.

Hm. I may be an alien with several eyes and an additional hand in my
nose, when programming conservatively ;)

OK. In next patchset, I'll remove such parentheses, as much as possible.


Thanks

Takashi Sakamoto


More information about the Alsa-devel mailing list