[alsa-devel] [PATCH 7/8] ASoC: Intel: add kcontrol to set parameter to sound effect module waves

[Mark Brown]

On Mon, Mar 02, 2015 at 03:36:17PM +0800, han.lu at intel.com wrote:

> +static int hsw_waves_param_get(struct snd_kcontrol *kcontrol,
> +				struct snd_ctl_elem_value *ucontrol)
> +{
> +	/* keep an empty function here to match alsa-lib calling */
> +	return 0;
> +}

No, if it's valid to omit this we should be able to remove the function
- but I'd really expect to always be able to read the current state of
any control.  Applications should be able to do that and then write the
value back without changing anything.  Either we should actually read
things back or this should return an error (which is presumably what the
core does if the function is missing).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150306/edd881f8/attachment.sig>