[alsa-devel] [PATCH 1/2] ASoC: soc-compress: add a config item for soc-compress

[Jie, Yang]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Friday, June 12, 2015 8:15 PM
> To: Jie, Yang
> Cc: tiwai at suse.de; alsa-devel at alsa-project.org; Girdwood, Liam R;
> vinod.koul at linux.intel.com; ramesh.babu at linux.intel.com; Zhang, Vivian
> Subject: Re: [PATCH 1/2] ASoC: soc-compress: add a config item for soc-
> compress
> 
> On Fri, Jun 12, 2015 at 07:59:15PM +0800, Jie Yang wrote:
> 
> > +config SND_SOC_COMPRESS
> > +	tristate
> > +	select SND_COMPRESS_OFFLOAD
> > +	default n
> > +
> 
> No need to specify default n, it is the default.  I'm not seeing any change

OK, will remove this default setting.

> here to make the drivers that do use compressed support select this symbol
 
As mentioned in commit message, we need add 'select SND_SOC_COMPRESS'
to driver  Kconfig(e.g. sound/soc/intel/Kconfig) when it is needed.

> and since there's no config text there's no way for users to enable this on a
> per system basis so this breaks all existing compressed audio support.
 
Do you mean I should add this message to 'Help' for this config item?
Per my understanding, no existing driver really uses this compressed audio
support currently, is that true?

~Keyon