[alsa-devel] [PATCH v3 0/2] Update ALSA driver to use media controller API
Shuah Khan
shuahkh at osg.samsung.com
Wed Jun 10 16:21:55 CEST 2015
This patch series updates ALSA driver to use media controller
API to share tuner with DVB and V4L2 drivers that control AU0828
media device. Two new interfaces are added to media controller
API to enable creating media device as a device resource. This
allows creating media device as a device resource on the main
struct device that is common to all drivers that control a single
media hardware and share resources on it. Drivers then can find
the common media device to register entities and manage links,
and pipelines.
Tested with and without CONFIG_MEDIA_CONTROLLER enabled.
Tested tuner entity doesn't exist case as au0828 v4l2
driver is the one that will create the tuner when it gets
updated to use media controller API.
Please note that au0828 updates media controller are necessary
before the resource sharing can work across ALSA and au0828
dvb and v4l2 drivers. This work is in progress and another
developer is working on it.
Changes since v1:
- Moved media specific code into new header and source file
- Created a new structure for media controller specific fields
- Added a new define USE_MEDIA_CONTROLLER to add media specific
code. This new define is defined only when Media Controller
support is enabled. New media specific code is active only
when this define is defined.
- Moved media_deviced_delete() check under !was_shutdown block
- Removed return check for media_device_init()
- Changed new Media Controller interface names for clarity. Now
they are named media_device_get_devres() and
media_device_find_devres().
- Calling media_entity_pipeline_stop() on a pipe that isn't active
appears to be safe. This needs further testing once AU0828
media controller patches are ready.
Changes since v2:
- Moved checks to define USE_MEDIA_CONTROLLER to Makefile
- Moved stubs for media controller specific functions to header
file.
- Added new register_notify operation to media_entity_operations
structure. This new hook is called when a new entity is
registered to allow other entities associated with the
media device to create link as needed.
- Added a new field to struct media_entity for entity owners
to save their private data.
- Is it safe for ALSA to call media_entity_remove_links()?
Laurent Pinchart, please comment.
- Do start/stop pipeline functions have to be concered about
V4l2? Are they safe the way they are?
Hans, please comment.
Shuah Khan (2):
media: media controller entity framework enhancements for ALSA
sound/usb: Update ALSA driver to use media controller API
drivers/media/media-device.c | 7 ++
include/media/media-entity.h | 4 +
sound/usb/Makefile | 15 +++-
sound/usb/card.c | 5 ++
sound/usb/card.h | 1 +
sound/usb/media.c | 185 +++++++++++++++++++++++++++++++++++++++++++
sound/usb/media.h | 47 +++++++++++
sound/usb/pcm.c | 10 ++-
sound/usb/quirks-table.h | 1 +
sound/usb/quirks.c | 9 ++-
sound/usb/stream.c | 3 +
sound/usb/usbaudio.h | 1 +
12 files changed, 285 insertions(+), 3 deletions(-)
create mode 100644 sound/usb/media.c
create mode 100644 sound/usb/media.h
--
2.1.4
More information about the Alsa-devel
mailing list