[alsa-devel] [RFC PATCH] ALSA: split params refinement to seperated file

Mark Brown broonie at kernel.org
Tue Jun 9 19:57:11 CEST 2015


On Mon, Jun 08, 2015 at 11:21:17AM +0200, Takashi Iwai wrote:

> Just begin with adding ifdefs instead of reshuffling the code.  This
> will make easier to understand what you're going to change.  At least,
> it's good enough for RFC.  After that, we can refactor the code.

Plus if the patches get applied it at least makes it easier for people
who do decide to do such major surgery.

> Removing the hw constraints refinement is rather a radical change.
> It's a part of the PCM core functionality, and removing it means that
> the driver has no ways to refuse the incompatible parameters even if
> it knows it's broken.  So, IMO, this is the very last resort.  We can
> start from ripping off lower hanging fruits.

Indeed, part of the reason I was asking about the split was to help me
figure out what takes the place of constraints - sounds like nothing?  I
wonder if we could have cards support this by providing fixed
configurations that we could check against using less code or something.
But like you say, we *must* have some other room for improvement.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150609/8ee281a2/attachment-0001.sig>


More information about the Alsa-devel mailing list