[alsa-devel] [PATCH v2 1/2] ASoC: wm_adsp: Add code_probe and codec_remove stubs

Richard Fitzgerald rf at opensource.wolfsonmicro.com
Tue Jun 9 18:13:56 CEST 2015


On Tue, Jun 09, 2015 at 05:00:43PM +0100, Mark Brown wrote:
> On Tue, Jun 09, 2015 at 04:16:56PM +0100, Richard Fitzgerald wrote:
> 
> > +	ret = wm_adsp2_codec_probe(&priv->core.adsp[0], codec);
> > +	if (ret)
> > +		return ret;
> > +
> 
> I'm still not a big fan of the double registration that's being done -
> if nothing else the fact that it's not also factoring out the creation
> of the DSP controls seems wrong.

I don't see the point of trying to fight against the design of ASoC with
the second probe. ASoC gives us what we need at the codec_probe stage
so why try to invent something different?


More information about the Alsa-devel mailing list