[alsa-devel] [PATCH v6 2/3] ALSA: hdac_ext: add hdac extended controller
Takashi Iwai
tiwai at suse.de
Mon Jun 8 17:42:25 CEST 2015
At Mon, 8 Jun 2015 21:02:59 +0530,
Vinod Koul wrote:
>
> On Mon, Jun 08, 2015 at 11:12:48AM +0200, Takashi Iwai wrote:
> > > +struct hdac_ext_link {
> > > + struct hdac_bus *bus;
> > > + int index;
> > > + void __iomem *ml_addr; /* link output stream reg pointer */
> > > + u32 lcaps; /* link capablities */
> > > + u16 lsdiid; /* link sdi identifier */
> > > + char codec[HDA_MAX_CODECS][32]; /* codecs connectes to the link */
> >
> > Do we need to keep the codec name string? Isn't it just codec address
> > we'd like to check the match...? If so, we may use bitmasks instead,
> > too.
> This is not for matching stuff (this is link structure and not codec)
> So we keep name of codec found on this link. When ASoC BE triggers we use
> codec name to find the link and use
But each codec name consists of just a few bits. Why do you need to
keep each codec name string?
Takashi
More information about the Alsa-devel
mailing list