[alsa-devel] [PATCH v6 1/3] ALSA: hdac_ext: add extended HDA bus

[Vinod Koul]

On Mon, Jun 08, 2015 at 03:38:22PM +0530, Vinod Koul wrote:
> > > +#define snd_hdac_ext_bus_ppcap_updateb(dev, reg, mask, val) \
> > > +	snd_hdac_ext_bus_ppcap_writeb(dev, reg, \
> > > +			       (snd_hdac_ext_bus_ppcap_readb(dev, reg) & \
> > > +				~(mask)) | (val))
> > 
> > It's not necessarily good to wrap all with such macros.
> > For azx_write*(), I kept them as is for reducing the amount of useless
> > code rewrites.  But for new codes, I don't think it's always worth...
> Actually while updating the patch for ext I was wondering about this too.
> 
> So we cna remove these and use snd_hdac_chip_writel/w/b here
As Jeeja pointed we can't use snd_hdac_chip_writel as we need to use a
different base. So we cna move this to use plain writel only

Any other ideas?

-- 
~Vinod