[alsa-devel] [RFC PATCH] ALSA: split params refinement to seperated file

Mark Brown broonie at kernel.org
Mon Jun 8 11:24:16 CEST 2015


On Mon, Jun 08, 2015 at 07:35:17AM +0000, Jie, Yang wrote:

> > I'd suggest that for review it'd be easier to have one patch for the move and
> > another for the change in behaviour: it's a bit hard to find the actual change
> > in what the kernel does in this diff and that's the bit that needs most careful
> > consideration.

> > git format-patch -M may also help.

> Umm, Liam also suggested that, it's really hard for reviewing, but I found that 
> "git format-patch -M" doesn't help for partially splitting/moving from a file
> to another/new file, I even tried '-M5%', but no luck. :(

> I can't find good way to make it better, any suggestion?

I think the thing I suggested about having one patch that only moves
code around and another that allows you to disable the constraining
would also help - the first patch will be big but mechanical which
helps.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150608/b48f1757/attachment.sig>


More information about the Alsa-devel mailing list