[alsa-devel] [RFC PATCH] ALSA: split params refinement to seperated file
Jie, Yang
yang.jie at intel.com
Mon Jun 8 09:35:17 CEST 2015
> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Friday, June 05, 2015 3:16 AM
> To: Jie, Yang
> Cc: tiwai at suse.de; alsa-devel at alsa-project.org; Girdwood, Liam R; Zhang,
> Vivian
> Subject: Re: [RFC PATCH] ALSA: split params refinement to seperated file
>
> On Thu, Jun 04, 2015 at 10:47:45PM +0800, Jie Yang wrote:
>
> > The change moves refinement functions from original pcm_native.c and
> > pcm_lib.c, to pcm_refine.c(similarly the declaration from pcm.h to
> > pcm_refine.h), so it is not so big as it looks like.
>
> I'd suggest that for review it'd be easier to have one patch for the move and
> another for the change in behaviour: it's a bit hard to find the actual change
> in what the kernel does in this diff and that's the bit that needs most careful
> consideration.
>
> git format-patch -M may also help.
Umm, Liam also suggested that, it's really hard for reviewing, but I found that
"git format-patch -M" doesn't help for partially splitting/moving from a file
to another/new file, I even tried '-M5%', but no luck. :(
I can't find good way to make it better, any suggestion?
~Keyon
More information about the Alsa-devel
mailing list