[alsa-devel] ASoC: PATCH: wm8731 - reinitialize regmap cache after hardware reset

[Charles Keepax]

On Thu, May 28, 2015 at 09:34:09AM -0700, Sergey Kiselev wrote:
> Hi,
> 
> I am working on a machine driver that uses wm8731 codec and I've
> noticed that it will not work after rmmod/modprobe of that machine
> driver. The issue is that wm8731_probe() resets the hardware, but it
> doesn't reinitialize the regmap cache to the default values.
> 
> The patch below fixes this issue.
> 
> I also skimmed through other codecs, and some of them might have
> similar issue (wm8510.c, wm8711.c, wm8750.c, wm8753.c, wm8940.c,
> wm8960.c, wm8971.c, wm8974.c, wm8988.c, wm8990.c)
> 
> Another way to avoid this issue might be resetting the codec in the
> *_spi_probe()/*_i2c_probe(), so that it only gets reset once when
> codec is loading.
> 
> Thanks in advance for any comments/suggestions on the patch.
> 
> Thanks,
> Sergey
> 
> Signed-off-by: Sergey Kiselev <skiselev at gmail.com>
> 

In addition to the comments from Mark and Liam, if you could CC
patches at opensource.wolfsonmicro.com when submitting patches to
the Wolfson stuff, ensures we will see them going through, it is
easy to miss stuff on the generic lists.

Thanks,
Charles