[alsa-devel] [PATCH v4 5/7] ASoC: intel - add Skylake HDA audio driver

[Takashi Iwai]

At Mon, 1 Jun 2015 10:43:58 +0530,
Vinod Koul wrote:
> 
> > > +static int azx_acquire_irq(struct soc_hdac_bus *sbus, int do_disconnect)
> > > +{
> > > +	struct hda_skl *hda = to_hda_skl(sbus);
> > > +	struct hdac_bus *bus = hdac_bus(sbus);
> > > +	int ret = 0;
> > > +
> > > +	ret = request_threaded_irq(hda->pci->irq, azx_interrupt,
> > > +			azx_threaded_handler,
> > > +			hda->msi ? 0 : IRQF_SHARED,
> > > +			KBUILD_MODNAME, sbus);
> > 
> > Why not just always request the interrupt as shared - we don't seem to
> > care in the interrupt handling code?
> I think we can move this to shared only

MSI is the exclusive irq, thus shouldn't be shared.


Takashi