[alsa-devel] Applied "ASoC: xtfpga-i2s: Add missing __rcu annotation" to the asoc tree
Mark Brown
broonie at kernel.org
Wed Jul 29 16:13:03 CEST 2015
The patch
ASoC: xtfpga-i2s: Add missing __rcu annotation
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From d32e03f0b6f9b4ad260feca1c5c938a882066de9 Mon Sep 17 00:00:00 2001
From: Lars-Peter Clausen <lars at metafoo.de>
Date: Mon, 27 Jul 2015 10:56:28 +0200
Subject: [PATCH] ASoC: xtfpga-i2s: Add missing __rcu annotation
tx_substeam is accessed using the RCU API and hence should have the __rcu
annotation. Fixes the following sparse warnings:
sound/soc/xtensa/xtfpga-i2s.c:165:24: error: incompatible types in
comparison expression (different address spaces)
sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream
[noderef] <asn:4>*' versus
sound/soc/xtensa/xtfpga-i2s.c:165:24: error: 'struct snd_pcm_substream *'
sound/soc/xtensa/xtfpga-i2s.c:255:24: error: incompatible types in
comparison expression (different address spaces)
sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream
[noderef] <asn:4>*' versus
sound/soc/xtensa/xtfpga-i2s.c:255:24: error: 'struct snd_pcm_substream *'
Signed-off-by: Lars-Peter Clausen <lars at metafoo.de>
Acked-by: Max Filippov <jcmvbkbc at gmail.com>
Signed-off-by: Mark Brown <broonie at kernel.org>
---
sound/soc/xtensa/xtfpga-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/xtensa/xtfpga-i2s.c b/sound/soc/xtensa/xtfpga-i2s.c
index 039f65e..8382ffa 100644
--- a/sound/soc/xtensa/xtfpga-i2s.c
+++ b/sound/soc/xtensa/xtfpga-i2s.c
@@ -75,7 +75,7 @@ struct xtfpga_i2s {
* stream in the pcm_close callback it synchronizes with the interrupt
* handler by means of synchronize_rcu call.
*/
- struct snd_pcm_substream *tx_substream;
+ struct snd_pcm_substream __rcu *tx_substream;
unsigned (*tx_fn)(struct xtfpga_i2s *i2s,
struct snd_pcm_runtime *runtime,
unsigned tx_ptr);
--
2.1.4
More information about the Alsa-devel
mailing list