[alsa-devel] [PATCH 5/6] ASoC: Intel: Skylake: Add DSP module init and binding routines

[Mark Brown]

On Tue, Jul 21, 2015 at 11:53:59PM +0530, Vinod Koul wrote:

> +int skl_bind_unbind_modules(struct skl_sst *ctx, struct skl_module_cfg
> +	*src_module, struct skl_module_cfg *dst_module, bool bind)
> +{
> +	dev_dbg(ctx->dev, "%s: src module_id = %d  src_instance=%d\n",
> +		__func__, src_module->id.module_id, src_module->id.instance_id);
> +	dev_dbg(ctx->dev, "%s: dst_module=%d dst_instacne=%d\n", __func__,
> +		 dst_module->id.module_id, dst_module->id.instance_id);
> +
> +	dev_dbg(ctx->dev, "src_module state = %d dst module state = %d\n",
> +		src_module->m_state, dst_module->m_state);
> +
> +	if (bind)
> +		return skl_bind_modules(ctx, src_module, dst_module);
> +	else
> +		return skl_unbind_modules(ctx, src_module, dst_module);
> +}

I'm not sure I understand the purpose of this function - why not just
use the bind and unbind functions directly if they share nothing?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150729/901a362e/attachment.sig>