[alsa-devel] [PATCH 3/6] ASoC: Intel: Skylake: Add functions for DSP module configuration

[Mark Brown]

On Tue, Jul 21, 2015 at 11:53:57PM +0530, Vinod Koul wrote:

> +	case SKL_CH_CFG_I2S_DUAL_STEREO_1:
> +		config = (0xFFFF00FF | (SKL_CHANNEL_LEFT << 8)
> +			| (SKL_CHANNEL_RIGHT << 12));
> +		break;
> +
> +	default:
> +		config =  0xFFFFFFFF;
> +	}

Missing break.

> +/*
> + * Allocates queue for each module.
> + * if dynamic, the pin_index is allocated 0 to max_pin.
> + * In static, the pin_index is fixed based on module_id and instance id
> + */
> +static int skl_alloc_queue(struct skl_module_pin *mpin,
> +			struct skl_module_inst_id id, int max)
> +{
> +	struct skl_module_pin m_pin = skl_get_queue(mpin, id, max);
> +
> +	if (m_pin.pin_index < 0)
> +		return -EINVAL;
> +
> +	if (m_pin.is_dynamic) {
> +			m_pin.in_use = true;
> +			m_pin.id.module_id = id.module_id;
> +			m_pin.id.instance_id = id.instance_id;
> +	}

Double indentation here.  It's really unclear to me why a static pin
doesn't need to get merked as in use?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150729/b6dc1457/attachment.sig>