[alsa-devel] [PATCH v2 2/4] ASoC: fsl_esai: Add driver suspend and resume to support MEGA Fast

[Mark Brown]

On Wed, Jul 08, 2015 at 03:22:28PM +0800, Zidan Wang wrote:

> @@ -722,7 +748,9 @@ static const struct regmap_config fsl_esai_regmap_config = {
>  
>  	.max_register = REG_ESAI_PCRC,
>  	.readable_reg = fsl_esai_readable_reg,
> +	.volatile_reg = fsl_esai_volatile_reg,
>  	.writeable_reg = fsl_esai_writeable_reg,
> +	.cache_type = REGCACHE_RBTREE,

Do you really want to use a rbtree here without cache defaults or
marking all registers as volatile?  As soon as we try to allocate a
cache node we'll be doing allocations inside a spinlock which isn't
terribly clever.  I'd expect a flat cache, ideally with defaults
provided (though that isn't essential, everything will default to 0) or
an rbtree with defaults provided.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150720/6a5de092/attachment-0001.sig>