[alsa-devel] [PATCH v4] ASoC: rt5645: Check if codec is initialized in workqueue handler

[Nicolas Boichat]

On Fri, Jul 17, 2015 at 7:12 PM, Mark Brown <broonie at kernel.org> wrote:
> On Fri, Jul 17, 2015 at 10:36:57AM +0800, Nicolas Boichat wrote:
>
>> This replaces 3c2234569cfff83718792f810a9bb855b78c2473, and applies on top of
>> Linux 4.2-rc1, so that this patch can be applied in its own branch, without
>> triggering a compile warning.
>
> Please provide human readable descriptions of commits so your mails are
> directly readable.

Noted, sorry about that.

3c2234569cfff83718792f810a9bb855b78c2473 is "ASoC: rt5645: Check if
codec is initialized in workqueue handler" (same commit title), which
you applied yesterday on fix/rt5645, and, as it stands, triggers a
compile-time warning as it depends on "ASoC: rt5645: Remove
irq_jack_detection function", which you applied on topic/rt5645 3 days
ago.

Note that, after you replace the commit in fix/rt5645, and merge
topic/rt5645, we'll need to remove the return value, as the hunk above
will have moved from irq_jack_detection to rt5645_jack_detect_work,
which returns void (this probably won't appear as an obvious merge
conflict...).

I'll provide a patch for that, if you are ok with replacing the commit
above (otherwise we'll need 2 short patches: one in fix/rt5645, and
revert it in topic/rt5645).

Thanks!