[alsa-devel] [asoc:fix/rt5645 1/1] sound/soc/codecs/rt5645.c:2947:3: warning: 'return' with no value, in function returning non-void

[Mark Brown]

On Thu, Jul 16, 2015 at 09:03:29PM +0800, Nicolas Boichat wrote:
> On Thu, Jul 16, 2015 at 8:32 PM, kbuild test robot

> >    sound/soc/codecs/rt5645.c: In function 'rt5645_irq_detection':
> >>> sound/soc/codecs/rt5645.c:2947:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
> >       return;
> >       ^

> Are you sending this patch to stable@?

My git tree is public...  I'd not Cced it to stable but it looks like
it's supposed to be a bug fix so I applied it as a bug fix.

> This happens because I rebased the patch on f312bc59 "ASoC: rt5645:
> Remove irq_jack_detection function" (which was your for-next at the
> time), so it probably shouldn't be applied in its own branch...

> The return value is ignored anyway, so the code should work as
> intended, but a "return 0;", or -EINVAL, would be more proper...

Please send a fixed version unless the issue doesn't exist in Linus'
tree.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150716/3572dd8e/attachment-0001.sig>