[alsa-devel] [asoc:fix/rt5645 1/1] sound/soc/codecs/rt5645.c:2947:3: warning: 'return' with no value, in function returning non-void

[Nicolas Boichat]

Hi Mark,

On Thu, Jul 16, 2015 at 8:32 PM, kbuild test robot
<fengguang.wu at intel.com> wrote:
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git fix/rt5645
> head:   3c2234569cfff83718792f810a9bb855b78c2473
> commit: 3c2234569cfff83718792f810a9bb855b78c2473 [1/1] ASoC: rt5645: Check if codec is initialized in workqueue handler
> config: i386-randconfig-x009-201528 (attached as .config)
> reproduce:
>   git checkout 3c2234569cfff83718792f810a9bb855b78c2473
>   # save the attached .config to linux build tree
>   make ARCH=i386
>
> All warnings (new ones prefixed by >>):
>
>    sound/soc/codecs/rt5645.c: In function 'rt5645_irq_detection':
>>> sound/soc/codecs/rt5645.c:2947:3: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
>       return;
>       ^

Are you sending this patch to stable@?

This happens because I rebased the patch on f312bc59 "ASoC: rt5645:
Remove irq_jack_detection function" (which was your for-next at the
time), so it probably shouldn't be applied in its own branch...

The return value is ignored anyway, so the code should work as
intended, but a "return 0;", or -EINVAL, would be more proper...

Thanks,