[alsa-devel] [PATCH v2 1/6] ASoC: Intel: Add helper to poll register for DSP status

[Vinod Koul]

On Wed, Jul 08, 2015 at 07:36:21PM +0100, Mark Brown wrote:
> On Fri, Jul 03, 2015 at 04:04:02PM +0530, Vinod Koul wrote:
> 
> > +	for (time = 0; time < timeout; time++) {
> > +		if ((sst_dsp_shim_read_unlocked(ctx, offset) & mask) == expected_value)
> > +			break;
> > +
> > +		mdelay(1);
> > +	}
> 
> mdelay() not msleep()?  If we're waiting for multiple miliseconds that
> could be lots of busy waiting.
Usually this should get reflected in 1st iteration as the register update
would get updated farrily quickly. msleep will add up lots of latency to
this.

Thanks
-- 
~Vinod
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150709/7e5d1a76/attachment.sig>