[alsa-devel] [PATCH] ASoC: rt286: set idle_bias_off to false

[Jie, Yang]

> -----Original Message-----
> From: Mark Brown [mailto:broonie at kernel.org]
> Sent: Thursday, January 29, 2015 6:52 PM
> To: Jie, Yang
> Cc: Bard Liao; lgirdwood at gmail.com; alsa-devel at alsa-project.org; Flove; Oder
> Chiou
> Subject: Re: [PATCH] ASoC: rt286: set idle_bias_off to false
> 
> On Thu, Jan 29, 2015 at 09:07:08AM +0000, Jie, Yang wrote:
> 
> Please fix your mailer to word wrap within paragraphs, your mails are very hard
> to read.
[Keyon] sorry for that, should fix it this time.
> 
> > > If jack detection should be disabled over suspend the machine driver
> > > should do that (eg, by setting a NULL jack).  It's actually common
> > > for systems to leave jack detection up over suspend as in systems
> > > like phones the jack can be a wake
> 
> > [Keyon] as my understanding, setting idle_bias_off to false won't
> > disable jack detection over suspend, only the action that poweroff the codec
> will disable it, Bard, is it correct?
> 
> Right, you've got it the wrong way round - the goal is turn off the widgets that
> are holding the device on.
> 
> > setting idle_bias_off to false is the easiest solution for us, it is
> > also reasonable here, because rt286 don't need soc core to set BIAS
> > OFF specially when in idle status, (BIAS_OFF and BIAS_STANDBY are same for
> it), and seems no side effect here.
> 
> Currently.  And to be honest I would have expected that the behaviour would
> be the same with widgets on regardless of the bias level so we probably want
> to fix that which would cause the same problem resurface even if it were
> bodged around for now.
[Keyon] OK, then I will try disable jack detection in the machine driver before calling snd_soc_suspend(), can you share example about how to set a NULL jack?