[alsa-devel] [PATCH] ASoC: Samsung: add missing I2C/SPI dependencies

[Mark Brown]

On Wed, Jan 28, 2015 at 10:28:55PM +0100, Arnd Bergmann wrote:
> The SND_SOC_ARNDALE_RT5631_ALC5631 selects the rt5631 codec
> that requires I2C to work, so we get a build error if I2C
> is disabled:

You rather buried the lead about there being other drivers in this
changelog, makes the code a bit surprising when you find it.

>  config SND_SOC_SPEYSIDE
>  	tristate "Audio support for Wolfson Speyside"
> -	depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410
> +	depends on SND_SOC_SAMSUNG && MACH_WLF_CRAGG_6410 && SPI_MASTER
>  	select SND_SAMSUNG_I2S
>  	select SND_SOC_WM8996
>  	select SND_SOC_WM9081

Why only add a dependency on SPI here?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150129/740b01cf/attachment.sig>