[alsa-devel] [PATCH 3/5] ALSA: line6: Reorganize PCM stream handling

Chris Rorvick chris at rorvick.com
Wed Jan 28 06:50:16 CET 2015


On Tue, Jan 27, 2015 at 10:13 AM, Takashi Iwai <tiwai at suse.de> wrote:
> Secondly, the stream state are now managed in opened and running bit
> flags of each line6_pcm_stream.  Not only this a bit clearer than
> previous combined bit flags, this also gives a better abstraction.

Nice.

> diff --git a/sound/usb/line6/capture.c b/sound/usb/line6/capture.c
> index 21342a9dddd7..1184876f4e00 100644
> --- a/sound/usb/line6/capture.c
> +++ b/sound/usb/line6/capture.c
> @@ -67,20 +67,18 @@ static int submit_audio_in_urb(struct snd_line6_pcm *line6pcm)
>
>  /*
>         Submit all currently available capture URBs.
> +       must be called in line6pcm->out.lock context

s/out.lock/in.lock/


More information about the Alsa-devel mailing list