[alsa-devel] [PATCH] fm801: move to pcim_* and devm_* functions

Takashi Iwai tiwai at suse.de
Wed Jan 7 14:57:19 CET 2015


At Wed, 07 Jan 2015 14:43:41 +0100,
Takashi Iwai wrote:
> 
> At Wed, 7 Jan 2015 15:40:26 +0200,
> Andy Shevchenko wrote:
> > 
> > On Wed, Jan 7, 2015 at 3:31 PM, Takashi Iwai <tiwai at suse.de> wrote:
> > > At Wed, 7 Jan 2015 15:27:35 +0200,
> > > Andy Shevchenko wrote:
> > 
> > Regarding to the original patch, is it okay now to apply?
> 
> Yes.  If you prefer, I can apply it first alone.

OK, I found that the regions are released in pcim_release().  So,
there is no leak.

Meanwhile it means that pci_release_regions() is superfluous, too,
once when you enabled the managed mode via pcim_enable_device().
Could you resubmit a v2 patch with that removal?


thanks,

Takashi


More information about the Alsa-devel mailing list