[alsa-devel] [PATCH] ASoC: tegra: Add platform driver for rt5677 audio codec

[Anatol Pomozov]

Hi

On Mon, Dec 29, 2014 at 7:55 AM, Mark Brown <broonie at kernel.org> wrote:
> On Mon, Dec 29, 2014 at 05:25:59AM -0800, Anatol Pomozov wrote:
>> On Fri, Dec 26, 2014 at 8:38 AM, Mark Brown <broonie at kernel.org> wrote:
>
>> >> +#if defined(CONFIG_MODULES) && defined(MODULE)
>> >> +     request_module("snd_soc_tegra30_i2s");
>> >> +#endif
>
>> > What's this all about then?
>
>> Sorry, my question was not clear. I meant is it ok to put this
>> request_module() to upstream code? If not then just remove it before
>> merging my patch.
>
> What question, I'm not seeing a question in the patch (I'd expect it to
> be after the --- if one was being asked)?  I've no idea what it's there
> for so it's hard to tell, my first thought would be no and you need to
> fix whatever you're working around directly.


My question was related to dependency between i2s and codec driver
modules. See it here (in the middle of the message)
http://permalink.gmane.org/gmane.linux.alsa.devel/132054

Anyway I think it is not worth spending too much time on it. I resent
this patch without request_module().