[alsa-devel] [PATCH] MS Lifecam HD-5000: Don't attempt to get the sample rate

[Takashi Iwai]

At Fri, 13 Feb 2015 19:35:19 +0000,
Joe Turner wrote:
> 
> Hi Folks,
> 
> This is my first time doing anything kernel-related, so apologies in
> advance for any faux-pas which are to follow.  I hope this is at least
> going to the correct place!
> 
> Currently after setting the sample rate of USB devices the driver tries to
> get the sample rate back from the device, to check that the two match up.
> The Lifecam doesn't support getting the sample rate, and so this operation
> times-out, and we continue regardless.
> 
> Because the USB timeout is pretty long this causes issues with some apps,
> which begin to doubt the ability of the device to produce audio before the
> timeout is up and misbehave in various ways.  See
> https://www.google.co.uk/search?q=%22cannot+get+freq+at+ep+0x82%22 for a
> range of reports relating to this issue.
> 
> This patch adds a quirk so that rather than check the sample rate and
> timeout, we don't bother checking at all.
> 
> Hope this all looks okay.

The workaround would be OK as long as it really works.
But the patch needs to follow the standard coding style and resent in
a formal way.  Please read Documentation/SubmittingPatches.  Try to
run scripts/checkpatch.pl at least.


thanks,

Takashi