[alsa-devel] [PATCH v3] ASoC: rt286: add jack detection enable/disable APIs and export

[Michał Mirosław]

2015-02-06 7:40 GMT+01:00 Jie Yang <yang.jie at intel.com>:
[...]
> @@ -1012,6 +1039,8 @@ static irqreturn_t rt286_irq(int irq, void *data)
>         bool mic = false;
>         int status = 0;
>
> +       if (!rt286->jack)
> +               return IRQ_HANDLED;
>         rt286_jack_detect(rt286, &hp, &mic);
>
>         /* Clear IRQ */

This seems wrong. Are you sure you want to return IRQ_HANDLED when you
did nothing to handle the interrupt?

Best Regards,
Michał Mirosław