[alsa-devel] [PATCH v3 1/2] ASoC: rt5645: add API to select ASRC clock source

[Mark Brown]

On Tue, Feb 03, 2015 at 12:03:47PM -0800, yang.a.fang at intel.com wrote:
> From: "Fang, Yang A" <yang.a.fang at intel.com>
> 
> This patch defines an API to select the clock source for specified filters.

This doesn't apply against current code, looks like a conflict with the
rt5650 support patch.  Please check and resend.

> +	if ((clk_src != RT5645_CLK_SEL_SYS) &&
> +	    (clk_src != RT5645_CLK_SEL_I2S1_ASRC) &&
> +	    (clk_src != RT5645_CLK_SEL_I2S2_ASRC) &&
> +	    (clk_src != RT5645_CLK_SEL_SYS2))
> +			return -EINVAL;

That return statement is indented a bit far (it should just be a tab,
it's not really anything to do with the constants so shouldn't be lined
up with them).  The whole thing would be better written as a switch
statement (return -EINVAL in the default case and break on a known
source).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20150204/7c30d545/attachment.sig>