[alsa-devel] [PATCH 0/3] snd-bcd2000: add audio support and control interface

Takashi Iwai tiwai at suse.de
Sun Feb 1 10:14:48 CET 2015


At Sat, 31 Jan 2015 22:34:22 +0100,
Mario Kicherer wrote:
> 
> The current version of the driver only provides a MIDI interface
> to read controller status and switch LEDs. These patches add audio
> playback and capture support as well as a control interface to
> switch between Phono A and Mic input.

The patches are almost good but there are a few issues, especially the
biggest problem is the empty changelog.  Usually the empty changlog
already indicates something wrong, except for trivial fixes or
conversions.  If you have some words in the cover letter, such details
can be put into each patch changelog, too, at least.


thanks,

Takashi


More information about the Alsa-devel mailing list