[alsa-devel] [PATCH] ASoC: arizona: Exit startup early if no runtime
Charles Keepax
ckeepax at opensource.wolfsonmicro.com
Tue Dec 29 10:46:40 CET 2015
On Thu, Dec 24, 2015 at 07:41:05PM +0000, Mark Brown wrote:
> On Wed, Dec 23, 2015 at 12:48:01PM +0000, Charles Keepax wrote:
> > commit 9b8ef9f6b3fc ("ASoC: dapm: Add startup & shutdown for dai_links")
> >
> > Added support for calling startup on CODEC to CODEC links, however this
> > is called with a NULL runtime pointer. There isn't really a sensible way
> > to pass a valid runtime pointer to a CODEC to CODEC link at the moment,
> > so we need to make the startup function safe for NULL runtimes. This
> > patch returns from the Arizona startup function early if there is no
> > runtime.
>
> We need a bit more here about why it's safe to just skip this code - it
> is actually safe since we're just setting constraints for userspace but
> that's not something the reader can tell without looking for more
> context.
Yeah no problem I will respin and send out a new version today.
Thanks,
Charles
More information about the Alsa-devel
mailing list