[alsa-devel] [PATCH 0/8] ALSA: oxfw: obsolete snd-scs1x with snd-oxfw

[Takashi Sakamoto]

On 2015年12月22日 19:53, Takashi Iwai wrote:
> On Tue, 22 Dec 2015 11:44:49 +0100,
> Takashi Sakamoto wrote:
>>
>> Hi,
>>
>> On Dec 22 2015 18:17, Takashi Iwai wrote:
>>> On Tue, 22 Dec 2015 01:15:38 +0100,
>>> Takashi Sakamoto wrote:
>>>>
>>>> Hi,
>>>>
>>>> This patchset update a part of my previous RFCv2 (patch 10-17).
>>>> [alsa-devel] [RFC][PATCH 00/17 v2] ALSA: oxfw: refactoring and merging scs1x module
>>>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-December/101558.html
>>>>
>>>> This patchset should be accumurated to the other patches under reviewing.
>>>>
>>>> [alsa-devel] [PATCH 0/4] ALSA: oxfw: localize stuffs of old firewire-speakers module
>>>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-December/102071.html
>>>>
>>>>
>>>> This patchset obsoletes snd-scs1x module with snd-oxfw module because the models
>>>> supported by snd-scs1x module are based on OXFW971, which snd-oxfw supports, too.
>>>> So snd-oxfw should support them. As a result, one of the models gets packet
>>>> streaming functionality to receive PCM samples. This is a lack of
>>>> functionalities in snd-scs1x.
>>>>
>>>>
>>>> Usually I won't post additional patches during the others are under reviewing.
>>>> But it's near the end of year. I'd like to post these patches in advance to
>>>> avoid year-end busyness. I'm happy if you review them and these patches go
>>>> forward, then I can get a short rest in the year-end.
>>>>
>>>> I note that I have the other patches for ALSA dice module, too. I'm also happy
>>>> to start reviewing process for them after this patchset goes forward...
>>>>
>>>> Changes from RFCv2:
>>>>  * remove sound/firewire/scs1x.c (I forget it)
>>>>  * revise operations in rawmidi callbacks
>>>>
>>>> Takashi Sakamoto (8):
>>>>   ALSA: oxfw: add scs1x layer
>>>>   ALSA: oxfw: allocate own address region for SCS.1 series
>>>>   ALSA: oxfw: copy handlers of asynchronous transaction for MIDI capture
>>>>   ALSA: oxfw: add MIDI capture port for SCS.1 models
>>>>   ALSA: oxfw: copy handlers of asynchronous transaction for MIDI
>>>>     playback
>>>>   ALSA: oxfw: add MIDI playback port for SCS.1 models
>>>>   ALSA: oxfw: obsolete scs1x module
>>>>   ALSA: oxfw: add stream format quirk for SCS.1 models
>>>
>>> The changes look good to me, but the patches aren't cleanly
>>> applicable.  Please rebase the patches to for-next branch and
>>> resubmit.
>>
>> Thanks for your review, while this patchset is based on patches which
>> are not accepted yet. Would you please review the four patches (titled
>> as ALSA: oxfw: localize stuffs of old firewire-speakers module), too?
>> Then you can apply whole these patches without rebasing.
> 
> Alright, I applied both series now.  Thanks.

OK. Thanks.


Takashi Sakamoto