[alsa-devel] [PATCH] ASoC: rt5616: add rt5616 codec driver

Mark Brown broonie at kernel.org
Sat Dec 19 13:01:33 CET 2015


On Tue, Dec 15, 2015 at 02:57:41PM +0800, Bard Liao wrote:

A couple of very minor issues with the control names here but otherwise
this looks good - I'll apply this, please send followup patches fixing
these:

> +	/* IN1/IN2 Control */
> +	SOC_SINGLE_TLV("IN1 Boost", RT5616_IN1_IN2,
> +		RT5616_BST_SFT1, 8, 0, bst_tlv),
> +	SOC_SINGLE_TLV("IN2 Boost", RT5616_IN1_IN2,
> +		RT5616_BST_SFT2, 8, 0, bst_tlv),

These should be " Boost Volume".

> +	/* ADC Boost Volume Control */
> +	SOC_DOUBLE_TLV("ADC Boost Gain", RT5616_ADC_BST_VOL,
> +			RT5616_ADC_L_BST_SFT, RT5616_ADC_R_BST_SFT,
> +			3, 0, adc_bst_tlv),

Boost Volume (like the comments says!).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151219/828f9cd7/attachment.sig>


More information about the Alsa-devel mailing list