[alsa-devel] [PATCH 1/3] rcar: ctu: Avoid use of ret uninitialised

Mark Brown broonie at kernel.org
Mon Dec 14 13:07:29 CET 2015


We use ret as the return value from the rsnd_ctu_probe() but if there
are no child nodes and no errors then we will never initialize ret leading
to build warnings. Ensure ret is initialized before we iterate over the
child nodes to avoid this.

Signed-off-by: Mark Brown <broonie at kernel.org>
---

Perhaps this should be an error instead?  It's not like it's a sensible
configuration...

 sound/soc/sh/rcar/ctu.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/sh/rcar/ctu.c b/sound/soc/sh/rcar/ctu.c
index 7c1e190cd389..d53a225d19e9 100644
--- a/sound/soc/sh/rcar/ctu.c
+++ b/sound/soc/sh/rcar/ctu.c
@@ -111,6 +111,7 @@ int rsnd_ctu_probe(struct rsnd_priv *priv)
 	priv->ctu	= ctu;
 
 	i = 0;
+	ret = 0;
 	for_each_child_of_node(node, np) {
 		ctu = rsnd_ctu_get(priv, i);
 
-- 
2.6.2



More information about the Alsa-devel mailing list