[alsa-devel] [PATCH v3 08/15] ASoC: hdac_hdmi: Create widget/route based on nodes enumerated

[Subhransu S. Prusty]

On Mon, Dec 07, 2015 at 05:14:41PM +0100, Takashi Iwai wrote:
> On Mon, 07 Dec 2015 22:24:22 +0100,
> Subhransu S. Prusty wrote:
> >  	return pin->num_mux_nids;
> >  }
> >  
> > -static void hdac_hdmi_fill_widget_info(struct snd_soc_dapm_widget *w,
> > -				enum snd_soc_dapm_type id,
> > -				const char *wname, const char *stream)
> > +static void hdac_hdmi_fill_widget_info(struct device *dev,
> > +				struct snd_soc_dapm_widget *w,
> > +				enum snd_soc_dapm_type id, void *priv,
> > +				const char *wname, const char *stream,
> > +				struct snd_kcontrol_new *wc, int numkc)
> >  {
> >  	w->id = id;
> > -	w->name = wname;
> > +	w->name = devm_kstrdup(dev, wname, GFP_KERNEL);
> 
> Missing NULL check.  Not only here but in handful places in this
> patch.

Sorry to have missed to add check on these. Will fix them.

Regards,
Subhransu
> 
> 
> Takashi

--