[alsa-devel] [PATCH 1/3] ALSA: pcm: add IEC958 channel status update

[Takashi Iwai]

On Wed, 02 Dec 2015 15:22:04 +0100,
Moise Gergaud wrote:
> 
> Add a helper to update only the IEC958 channel status sampling freq and
> word length parameters from an ALSA snd_pcm_runtime structure, taking
> account of the sample rate and sample size.
> 
> Signed-off-by: Moise Gergaud <moise.gergaud at st.com>
> Acked-by: Arnaud Pouliquen <arnaud.pouliquen at st.com>
> ---
>  include/sound/pcm_iec958.h | 19 ++++++++++-
>  sound/core/pcm_iec958.c    | 78 +++++++++++++++++++++++++++++++---------------
>  2 files changed, 71 insertions(+), 26 deletions(-)
> 
> diff --git a/include/sound/pcm_iec958.h b/include/sound/pcm_iec958.h
> index 0eed397..0c84c69 100644
> --- a/include/sound/pcm_iec958.h
> +++ b/include/sound/pcm_iec958.h
> @@ -3,7 +3,24 @@
>  
>  #include <linux/types.h>
>  
> +#ifdef CONFIG_SND_PCM_IEC958
>  int snd_pcm_create_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs,
> -	size_t len);
> +				   size_t len);
> +
> +int snd_pcm_update_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs,
> +				   size_t len);
> +#else
> +int snd_pcm_create_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs,
> +				   size_t len)
> +{
> +	return len;
> +}
> +
> +int snd_pcm_update_iec958_consumer(struct snd_pcm_runtime *runtime, u8 *cs,
> +				   size_t len)
> +{
> +	return len;
> +}

These must be static inline.
And, shouldn't they return an error?


Takashi