[alsa-devel] [PATCH 3/3] ASoC: Implement DAI links in a list & define API to add/remove a link

[Mark Brown]

On Mon, Nov 23, 2015 at 11:04:04AM -0500, mengdong.lin at linux.intel.com wrote:

A couple of small things but otherwise this looks fine:

> +	struct snd_soc_dai_link *dai_link;  /* predefined links only */
> +	int num_links;  /* predefined links only */
> +	struct list_head dai_link_list; /* all links */
> +	int num_dai_links;

Why are we keeping a count of num_dai_links?  I can't see any users.

> +	/* add predefined DAI links to the list */
> +	for (i = 0; i < card->num_links; i++)
> +		snd_soc_add_dai_link(card, card->dai_link+i);

Missing spaces around the + here.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://mailman.alsa-project.org/pipermail/alsa-devel/attachments/20151201/90620beb/attachment.sig>